Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI configurable MaxNumSpans while retrieving spans from ES. #1283

Merged
merged 3 commits into from
Jan 17, 2019
Merged

Add CLI configurable MaxNumSpans while retrieving spans from ES. #1283

merged 3 commits into from
Jan 17, 2019

Conversation

annanay25
Copy link
Member

@annanay25 annanay25 commented Jan 15, 2019 •
edited by yurishkuro
Loading

Signed-off-by: Annanay annanay.a@media.net

Which problem is this PR solving?

Short description of the changes

  • Added a CLI configurable option to limit the number of spans fetched in a single query to the ES backend.

Make MaxNumSpans CLI configurable
50ed4a7 
Signed-off-by: Annanay <annanay.a@media.net>
@ghost ghost assigned black-adder Jan 15, 2019
@ghost ghost added the review label Jan 15, 2019
@black-adder
Copy link
Contributor

My only question is are we ok with changing behavior that people are used to? If people upgrade jaeger, they'll automatically be hit with the 10000 limit and not know about it. Perhaps if no limit is set, we don't apply a default limit?

@codecov
Copy link

codecov bot commented Jan 15, 2019 •
edited
Loading

Codecov Report

Merging #1283 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1283   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         161     161           
  Lines        7198    7206    +8     
======================================
+ Hits         7198    7206    +8
Impacted Files Coverage Δ
plugin/storage/es/spanstore/reader.go 100% <100%> (ø) ⬆️
plugin/storage/es/options.go 100% <100%> (ø) ⬆️
plugin/storage/es/factory.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b034c...9e4bb5f. Read the comment docs.

@annanay25
Copy link
Member Author

@black-adder; this makes sense.

However, we could mention the reasons for adopting such a limit in the docs (that it could overwhelm the query-service) and mention that it could be overwritten using the flag in the release notes.

@black-adder black-adder merged commit d64cb70 into jaegertracing:master Jan 17, 2019
@ghost ghost removed the review label Jan 17, 2019
@yurishkuro
Copy link
Member

please add to the changelog.

is the behavior actually different from before? I thought we already had another 10k limit in the code.

@yurishkuro yurishkuro mentioned this pull request Jan 18, 2019
Closed
4 tasks
@yurishkuro yurishkuro mentioned this pull request May 15, 2023
Merged
@yurishkuro
Copy link
Member

This is being reverted in #4336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@objectiser objectiser Awaiting requested review from objectiser

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tiffon tiffon Awaiting requested review from tiffon

@vprithvi vprithvi Awaiting requested review from vprithvi

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees

@black-adder black-adder

Labels
storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annanay25 @black-adder @yurishkuro @pavolloffay